js: fix initialize to deposit 1sol#43
Merged
2501babe merged 1 commit intosolana-program:mainfrom Jan 15, 2025
Merged
Conversation
joncinque
approved these changes
Jan 15, 2025
Contributor
joncinque
left a comment
joncinque
left a comment
There was a problem hiding this comment.
Fly-by review: looks great!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
instead of refactoring all the tests to do something like
test_casewith both feature states, i just disabled the feature. this basically cannot fail if the minimum became 1sol because we hardcode 1sol. we would only need to do the gruntwork if the minimum was increased again, to more than 1solnote this was reported as an issue with
depositbut it is actually justinitialize. deposits of any size are fine, the program merely enforces that the pool has a whole must have at least 1soli also just merged a pr for cli tests to test against a validator with the 1lamp minimum, cli worked fine with no changes